[3.14] reinstate _OPTIMIZED & LTO_CFLAGS for correct flag handling in install_base.sh - #914
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/33570485145. Examine the logs at this URL for more detail. |
…l_base.sh deleted in 636474b without noticing remaining use
|
@isuruf, this is an attempt at a minimal fix for the sysconfig data, which is not getting populated as before due to missing variables after splitting the build scripts (as an aside, we could add a check for undefined variables if you'd like). However, we may want to improve the situation beyond the minimal fix. When everything was part of a single |
|
I think it's fine to duplicate for now |
|
I'm seeing errors compiling Python extensions because of gcc being called with a non-existent It kinda seems like Would that be fixed by this PR, or caused by this PR? This just started happening recently in CI, I reproduced locally using: Looking at the PR it kinda seems like it might be caused by this but I don't understand enough bash so before I go further figured I'd ask. |
|
Fixed in #919 |
Fix-up for #894 (noticed while working on #913), because the following code actually requires
_OPTIMIZEDto be setpython-feedstock/recipe/install_base.sh
Lines 40 to 59 in ec8a1a1