Remove unnecessary Autowired from Constructors - #3
Open
tiffanyfay wants to merge 1 commit into
Open
tiffanyfay wants to merge 1 commit into
tiffanyfay wants to merge 1 commit into
Conversation
tiffanyfay
commented
Jan 9, 2024
| private final Environment environment; | ||
|
|
||
| @Autowired | ||
| public ArchivingWorkflowListenerProperties(Environment environment) { |
Author
There was a problem hiding this comment.
Suggested change
| public ArchivingWorkflowListenerProperties(Environment environment) { | |
| @Autowired | |
| public ArchivingWorkflowListenerProperties(Environment environment) { |
| import java.time.temporal.ChronoUnit; | ||
|
|
||
| import org.springframework.beans.factory.annotation.Autowired; | ||
| import org.springframework.boot.context.properties.ConfigurationProperties; |
Author
There was a problem hiding this comment.
Suggested change
| import org.springframework.boot.context.properties.ConfigurationProperties; | |
| import org.springframework.beans.factory.annotation.Autowired; | |
| import org.springframework.boot.context.properties.ConfigurationProperties; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)Changes in this PR
Removed Autowired import/bean
This doesn't change the code behavior/functionality. It's just cleanup.
Describe the new behavior from this PR, and why it's needed
Issue # N/A
Alternatives considered
N/A
Describe alternative implementation you have considered