Fix Request object reuse bug in retry logic#103
Open
bradyyie wants to merge 1 commit intoconductor-oss:mainfrom
Open
Fix Request object reuse bug in retry logic#103bradyyie wants to merge 1 commit intoconductor-oss:mainfrom
bradyyie wants to merge 1 commit intoconductor-oss:mainfrom
Conversation
When a 429 rate limit response occurs, the retryFetch function was attempting to reuse the same Request object for subsequent retry attempts. Request objects in the Fetch API can only be used once - after their body is consumed, they become "used" and cannot be passed to fetch() again. This caused the error: "Cannot construct a Request with a Request object that has already been used" The fix clones the Request object before each fetch attempt, ensuring that retries always work with a fresh, unused Request object. This bug could manifest in high-traffic scenarios where rate limiting occurs, causing workflow executions to fail unexpectedly.
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 23 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Collaborator
|
can we branch off the conductor-oss/javascript-sdk in the same repo? the tests seem to be failing probably due to different repo? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a 429 rate limit response occurs, the retryFetch function was attempting to reuse the same Request object for subsequent retry attempts. Request objects in the Fetch API can only be used once - after their body is consumed, they become "used" and cannot be passed to fetch() again.
This caused the error:
"Cannot construct a Request with a Request object that has already been used"
The fix clones the Request object before each fetch attempt, ensuring that retries always work with a fresh, unused Request object.
This bug could manifest in high-traffic scenarios where rate limiting occurs, causing workflow executions to fail unexpectedly.