fix: implement fixes for issues #710, #721, #723, #725 - #727
Merged
Jaydbrown merged 1 commit intoSep 27, 2026
Merged
Conversation
…l#721, conduit-protocol#723, conduit-protocol#725 - conduit-protocol#721: Add cross-contract error code validation to prevent duplicates Enhanced validate-error-codes.py to check for duplicate error codes across different contracts, not just within each contract. - conduit-protocol#725: Add proposal execution expiry window to governor Implemented minimal proposal system with: - Proposal struct with execution window (e.g., 14 days) - propose() to create admin-gated proposals - execute_proposal() with expiry window enforcement - ProposalStatus tracking (Pending/Executed/Cancelled) - conduit-protocol#723: Add test for clawback prevention while paused Added sender_cannot_clawback_while_paused() test that verifies clawback fails with NotPaused error when stream is paused. - conduit-protocol#710: Add cancel_proposal capability for proposal author Implemented cancel_proposal() allowing authors to cancel pending proposals before voting starts.
|
@devjayy43 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes scripts/validate-error-codes.py: add CI check to prevent duplicate error code discriminants #721: Add cross-contract error code validation to prevent duplicates Enhanced validate-error-codes.py to check for duplicate error codes across different contracts, not just within each contract.
Closes contracts/governor: add proposal execution expiry window (e.g. must execute within 14 days of passing) #725: Add proposal execution expiry window to governor Implemented minimal proposal system with:
Closes tests/stream_pause_resume.rs: add test for withdrawal prevention while paused #723: Add test for clawback prevention while paused Added sender_cannot_clawback_while_paused() test that verifies clawback fails with NotPaused error when stream is paused.
Closes contracts/governor: add cancel_proposal capability for proposal author before voting starts #710: Add cancel_proposal capability for proposal author Implemented cancel_proposal() allowing authors to cancel pending proposals before voting starts.
What does this PR do?
Type of change
Related issue
Closes #
Changes
Checklist
cargo fmt --all— no diffcargo clippy --all-targets -- -D warnings— zero warningscargo test --all— all tests passchecked_*methodsrequire_auth()called before any state mutation in modified functionsCHANGELOG.mdupdated under[Unreleased]docs/architecture.mdupdated if design changedSecurity notes
Testing notes