Skip to content

feat: resolve issues #718, #719, #689, #690 - #730

Merged
Jaydbrown merged 1 commit into
conduit-protocol:mainfrom
bade2brazy:feat/issues-718-719-689-690
Sep 28, 2026
Merged

Jaydbrown merged 1 commit into
conduit-protocol:mainfrom
bade2brazy:feat/issues-718-719-689-690

Conversation

@bade2brazy

Copy link
Copy Markdown
Contributor

Summary

This PR resolves issues #718, #719, #689, and #690:

1. #718 – contracts/governor: emit DetailedVoteCast / vote event with voter rationale string or IPFS CID

  • Added cast_vote(env, voter, proposal_id, support) and cast_vote_with_rationale(env, voter, proposal_id, support, rationale) to DripGovernor.
  • Emits vote_cast event with (symbol_short!("vote"), voter, proposal_id) and data (support, rationale).
  • Added unit tests in contracts/governor/src/tests.rs.

2. #719 – contracts/stream: support cliff percentage unlock (e.g. upfront unlock at cliff followed by linear stream)

  • Added CliffConfig { cliff_time: u64, cliff_unlock_amount: i128 } to contracts/stream/src/storage.rs.
  • Added set_cliff and cliff_config entry points to DripStream.
  • Updated math::streamed_amount to credit cliff_unlock_amount immediately upon cliff_time expiration and linear streaming thereafter.
  • Added unit tests in contracts/stream/src/tests.rs.

3. #689 – scripts/deploy.sh: support dry-run simulation mode before broadcasting transactions

  • Added --dry-run flag to scripts/deploy.sh.
  • Validates the existence of all 6 WASM artifacts, checks deployer identity, and simulates salt derivations without broadcasting transactions.

4. #690 – contracts/stream: add recipient / third-party top-up capability to allow external gift funding

  • Updated DripStream::top_up to authenticate caller.require_auth() rather than restricting to sender/operator, allowing recipients and third-party benefactors to contribute additional funds.
  • Emits standard topped_up event.
  • Added unit test in contracts/stream/src/tests.rs.

Closes #718
Closes #719
Closes #689
Closes #690

…uit-protocol#689, conduit-protocol#690

- contracts/governor: emit DetailedVoteCast / vote event with voter rationale string or IPFS CID (closes conduit-protocol#718)
- contracts/stream: support cliff percentage unlock with cliff_unlock_amount in CliffConfig (closes conduit-protocol#719)
- scripts/deploy.sh: support dry-run simulation mode before broadcasting transactions (closes conduit-protocol#689)
- contracts/stream: add recipient top-up capability to allow external gift funding (closes conduit-protocol#690)
@drips-wave

drips-wave Bot commented Sep 28, 2026

Copy link
Copy Markdown

@bade2brazy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Jaydbrown
Jaydbrown merged commit 8f99269 into conduit-protocol:main Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants