feat: resolve issues #718, #719, #689, #690 - #730
Merged
Jaydbrown merged 1 commit intoSep 28, 2026
Merged
Conversation
…uit-protocol#689, conduit-protocol#690 - contracts/governor: emit DetailedVoteCast / vote event with voter rationale string or IPFS CID (closes conduit-protocol#718) - contracts/stream: support cliff percentage unlock with cliff_unlock_amount in CliffConfig (closes conduit-protocol#719) - scripts/deploy.sh: support dry-run simulation mode before broadcasting transactions (closes conduit-protocol#689) - contracts/stream: add recipient top-up capability to allow external gift funding (closes conduit-protocol#690)
|
@bade2brazy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves issues #718, #719, #689, and #690:
1. #718 –
contracts/governor: emit DetailedVoteCast / vote event with voter rationale string or IPFS CIDcast_vote(env, voter, proposal_id, support)andcast_vote_with_rationale(env, voter, proposal_id, support, rationale)toDripGovernor.vote_castevent with(symbol_short!("vote"), voter, proposal_id)and data(support, rationale).contracts/governor/src/tests.rs.2. #719 –
contracts/stream: support cliff percentage unlock (e.g. upfront unlock at cliff followed by linear stream)CliffConfig { cliff_time: u64, cliff_unlock_amount: i128 }tocontracts/stream/src/storage.rs.set_cliffandcliff_configentry points toDripStream.math::streamed_amountto creditcliff_unlock_amountimmediately uponcliff_timeexpiration and linear streaming thereafter.contracts/stream/src/tests.rs.3. #689 –
scripts/deploy.sh: support dry-run simulation mode before broadcasting transactions--dry-runflag toscripts/deploy.sh.4. #690 –
contracts/stream: add recipient / third-party top-up capability to allow external gift fundingDripStream::top_upto authenticatecaller.require_auth()rather than restricting to sender/operator, allowing recipients and third-party benefactors to contribute additional funds.topped_upevent.contracts/stream/src/tests.rs.Closes #718
Closes #719
Closes #689
Closes #690