Conversation
…uit-protocol#627, conduit-protocol#628 (conduit-protocol#625 conduit-protocol#626 conduit-protocol#627 conduit-protocol#628) - conduit-protocol#625: Add queryable max_batch_size getter to factory - conduit-protocol#626: Add stream_wasm_hash getter to factory - conduit-protocol#627: Optimize cancel_batch_streams deduplication with Map-backed set - conduit-protocol#628: Verify and document pause/unpause observability and event lineage Resolves conduit-protocol#625 Resolves conduit-protocol#626 Resolves conduit-protocol#627 Resolves conduit-protocol#628
|
@stephanieoghenemega-eng Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves issues 625, 626, 627, and 628 for the factory contract and pause observability:
max_batch_size(env: Env) -> u32read-only getter toDripFactoryexposingMAX_BATCH_SIZE, providing an on-chain source of truth for batch limits.stream_wasm_hash(env: Env) -> Result<BytesN<32>, Error>read-only getter toDripFactoryto query the currently configured stream WASM hash deployed by the factory.DripFactory::cancel_batch_streamsfrom("paused", governor)from governor passthrough caller events("fpaused", caller).Resolves #625
Resolves #626
Resolves #627
Resolves #628