feat(factory): make negative-cache TTL configurable via ConduitConfig (closes #602) - #684
Open
Ranjeet2063 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Exposes the
FactoryModulenegative address cache TTL as a configurable property onConduitConfig(negativeAddressCacheTtlMs), defaulting to 30,000ms (30s). Dashboards that poll at different rates can now accelerate cache eviction or disable caching entirely (closes #602).Key Changes
src/types/index.ts:negativeAddressCacheTtlMs?: numbertoConduitConfiginterface.src/factory.ts:DEFAULT_NEGATIVE_ADDRESS_CACHE_TTL_MS = 30_000.FactoryModulenow readsconfig.negativeAddressCacheTtlMs, falling back toDEFAULT_NEGATIVE_ADDRESS_CACHE_TTL_MS.Date.now() + this.negativeAddressCacheTtlMs.src/index.ts:FactoryModuleandDEFAULT_NEGATIVE_ADDRESS_CACHE_TTL_MSfrom root entry point.src/tests/factory.test.ts:README.md:negativeAddressCacheTtlMsin theConduitConfig Referencetable.Verification
npx vitest run src/tests/factory.test.ts: 21/21 tests passing.