fix(streams): safely parse stream flags without throwing on malformed ScVal (closes #617) - #690
Open
Ranjeet2063 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #617.
This pull request ensures
parseStreamInfohandles malformed or non-u32flagsvalues gracefully by falling back to 0 rather than raising an unhandled exception.Changes Made
src/streams.ts: WrappedscValToU32(m['flags'])in a safe conversion block with fallback to0ifm['flags']is present but contains an invalid/unexpectedScValtype.src/tests/parse-stream-info.test.ts: Added unit test verifying thatparseStreamInfofalls back toflags = 0whenflagsis not au32ScVal(e.g.scvString('not-a-u32')), keepingpaused,cancelled, andclawbackEnabledsafelyfalse.Acceptance Verification
npm test -- src/tests/parse-stream-info.test.tspasses with 7/7 tests green.npm run build).