Skip to content

chore(nonce): remove unused NonceManager implementation - #696

Open
ZacLou wants to merge 2 commits into
conduit-protocol:mainfrom
ZacLou:remove-nonce-manager
Open

chore(nonce): remove unused NonceManager implementation#696
ZacLou wants to merge 2 commits into
conduit-protocol:mainfrom
ZacLou:remove-nonce-manager

Conversation

@ZacLou

@ZacLou ZacLou commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Closes #603

This PR deletes the unused NonceManager implementation and its related tests, as requested in #603.

Changes

  • Removed src/nonce/NonceManager.ts
  • Removed nonce-specific test files:
    • src/tests/nonce-concurrent.test.ts
    • src/tests/nonce-manager-export.test.ts
    • src/tests/nonce-safe-acquire-backoff.test.ts
  • Trimmed the NonceManager.safeAcquire section from src/tests/bug-fixes-577-572.test.ts, keeping the unrelated #577 regression tests for u64ToScVal / estimateRequiredFee.
  • Removed NonceManager, NonceLock, and NonceManagerOptions exports from src/index.ts.

Verification

  • npx tsc --noEmit passes
  • Unit tests pass

…ests

Closes conduit-protocol#603

- Delete src/nonce/NonceManager.ts
- Delete nonce-specific test files
- Trim NonceManager tests from bug-fixes-577-572, keeping conduit-protocol#577 tests
- Remove NonceManager exports from src/index.ts
@ZacLou

ZacLou commented Sep 6, 2026

Copy link
Copy Markdown
Contributor Author

Fixed the CI build failure: rollup.config.mjs still listed the deleted src/nonce/NonceManager.ts as an entry module, causing the Rollup step to fail in both Test and Lint & Typecheck jobs. Removed that entry. Local npm run typecheck, npm run lint, and npm test all pass; npm run build cannot be verified on this macOS host due to a native rollup binary load issue, but the missing-entry error matches the CI log exactly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete the unused NonceManager implementation

1 participant