chore(nonce): remove unused NonceManager implementation - #696
Open
ZacLou wants to merge 2 commits into
Open
Conversation
…ests Closes conduit-protocol#603 - Delete src/nonce/NonceManager.ts - Delete nonce-specific test files - Trim NonceManager tests from bug-fixes-577-572, keeping conduit-protocol#577 tests - Remove NonceManager exports from src/index.ts
Contributor
Author
|
Fixed the CI build failure: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #603
This PR deletes the unused
NonceManagerimplementation and its related tests, as requested in #603.Changes
src/nonce/NonceManager.tssrc/tests/nonce-concurrent.test.tssrc/tests/nonce-manager-export.test.tssrc/tests/nonce-safe-acquire-backoff.test.tsNonceManager.safeAcquiresection fromsrc/tests/bug-fixes-577-572.test.ts, keeping the unrelated#577regression tests foru64ToScVal/estimateRequiredFee.NonceManager,NonceLock, andNonceManagerOptionsexports fromsrc/index.ts.Verification
npx tsc --noEmitpasses