fix(builder): validate C... contract recipient addresses in StreamBuilder (closes #609) - #697
Open
Ranjeet2063 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #609
Ensures full parity with #587 by validating Soroban contract ID (
C...) recipient addresses usingisValidAddressinStreamBuilderandConduitBatcher.Key Changes
src/builder.ts:isValidAddressforStreamBuilder._validateAddressandvalidatePayloadaddress validation.C...) are accepted and cleanly encoded into contract arguments viaAddress.toScVal().src/tests/builder-contract-recipient.test.ts:C...contract recipient acceptance inStreamBuilder.build().ScAddressTypeContractinsideStreamBuilder.toContractArgs().C...addresses.ConduitBatcher.execute.Verification
src/tests/builder-contract-recipient.test.ts.npm run buildgenerates clean ESM and CJS bundles.