feat(pgsql-test): add getErrorCode helper and fix pgpm_migrate exception context #548
+61
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a utility function to extract the error code from enhanced PostgreSQL error messages. Enhanced errors from PgTestClient include additional context (Where, Query, Values) on subsequent lines. This helper returns only the first line containing the actual error code. This is useful for tests that need to assert specific error codes while still benefiting from the enhanced debugging context.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Update snapshot expectations to match the new error format from pgpm_migrate: - hint field now returns '' instead of undefined - where field now shows 'line 73 at RAISE' instead of 'line 46 at EXECUTE' - Some fields changed from undefined to '' (empty string) - Error messages now include enhanced context (Detail, Where lines)
…dures Use simple RAISE instead of RAISE EXCEPTION USING to preserve the full PostgreSQL exception context including SQL statements in the 'where' field. The previous approach captured diagnostics but lost the PG_EXCEPTION_CONTEXT when re-raising, which removed valuable debugging information like the actual SQL statement that failed.
devin-ai-integration
bot
changed the title
…ontext The error message snapshots now include the enhanced debugging context (Where, Detail, Internal Query, etc.) that pgsql-test appends to error messages. This is the correct behavior - these tests verify that enhanced error messages work correctly in the pgpm migration flow. The error fields snapshots continue to show the raw PostgreSQL error properties including the SQL statement context in the 'where' field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(pgsql-test): add getErrorCode helper and fix pgpm_migrate exception context
Summary
This PR makes two related changes:
1. Add
getErrorCode()helper to pgsql-testSince pgsql-test 2.21.0,
PgTestClientappends additional debug context (Where, Query, Values) to error messages by default. This breaks tests that use exact string matching likeexpect(err.message).toEqual('NONEXISTENT_TYPE').The new helper extracts just the first line (the actual error code):
2. Fix pgpm_migrate exception handling to preserve SQL context
The
pgpm_migrate.deployandpgpm_migrate.revertprocedures were usingRAISE EXCEPTION USINGto re-raise errors, which loses thePG_EXCEPTION_CONTEXT(including the actual SQL statement that failed).Changed to use simple
RAISE;which preserves the full original exception context, keeping valuable debugging info like:Updates since last revision
RAISE EXCEPTION USINGtoRAISE;in bothdeployandrevertprocedures to preserve original exception contexterr.message. This is correct behavior - these tests verify enhanced error messages work in the migration flow.Review & Testing Checklist for Human
pnpm testinpostgres/pgsql-test/) and verify all pgpm-migration-errors snapshots pass - the snapshots were updated based on CI output, not local testingwherefield (should show "line 46 at EXECUTE", not "line 73 at RAISE")RAISE;changeRecommended test plan:
pnpm testinpostgres/pgsql-test/wherefieldNotes
This is part of fixing the test failures in constructive-db PR #190, where the pgsql-test upgrade caused tests to fail due to enhanced error message formatting.
Link to Devin run: https://app.devin.ai/sessions/6b89db7666a04391bbc93c493698f0df
Requested by: Dan Lynch (@pyramation)