Cg2: Add the ability to filter stats #387
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A large user of this library (unsurprisingly) is the containerd daemon, and specifically through the CRI entrypoint. There's quite a few stats we gather that are never bubbled up the chain when requested through that funnel. The stats never used are: MemoryEvents, Rdma, Hugetlb, and IO. We should likely do the same to cg1, but if we want to add it to the Cgroup interface it'd be a breaking change. Signed-off-by: Danny Canter <[email protected]>
fuweid
approved these changes
Jan 15, 2026
| metrics.MemoryEvents, err = readMemoryEvents(c.path) | ||
| if err != nil { | ||
| return nil, err | ||
| if mask&StatMemoryEvents != 0 { |
Member
There was a problem hiding this comment.
I like this idea. I was thinking adding new function to cgroupv2 object to get event information.
This solution looks good!
Member
Author
There was a problem hiding this comment.
I actually went down this rabbit hole because I wanted a way to solely just get the memory events also.. But this seemed a little bit easier to digest than a new method that solely returned those 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A large user of this library (unsurprisingly) is the containerd daemon, and specifically through the CRI entrypoint. There's quite a few stats we gather that are never bubbled up the chain when requested through that funnel. The stats never used are:
MemoryEvents, Rdma, Hugetlb, and IO.
We should likely do the same to cg1 (#370), but if we want to add it to the Cgroup interface it'd be a breaking change.