[Feat] Support reconvert image from nydus to oci (Update for PR #677) #679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J-jxr
force-pushed
the
jxr-pr677-update
branch
from
3766d81 to
e249a49
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #679 +/- ##
==========================================
- Coverage 20.89% 20.59% -0.31%
==========================================
Files 122 123 +1
Lines 11068 11232 +164
==========================================
Hits 2313 2313
- Misses 8436 8600 +164
Partials 319 319
🚀 New features to boost your workflow:
|
Signed-off-by: Yang Kaiyong <[email protected]>
Signed-off-by: Yang Kaiyong <[email protected]>
J-jxr
force-pushed
the
jxr-pr677-update
branch
9 times, most recently
from
79ccf90 to
62c9f24
Compare
J-jxr
force-pushed
the
jxr-pr677-update
branch
7 times, most recently
from
9e0c04b to
b958d78
Compare
BraveY
reviewed
Nov 21, 2025
|
|
||
| func MergeLayers(ctx context.Context, cs content.Store, descs []ocispec.Descriptor, opt MergeOption) (*ocispec.Descriptor, []ocispec.Descriptor, error) { | ||
| panic("not implemented") | ||
| } |
pkg/converter/reconvert_unix.go
Outdated
| return nil, nil | ||
| } | ||
|
|
||
| if !images.IsManifestType(newDesc.MediaType) && !images.IsIndexType(newDesc.MediaType) { |
Contributor
There was a problem hiding this comment.
This if statement seems unnecessary; we only need to handle the Manifest type, and all others can be returned directly.
pkg/converter/convert_unix.go
Outdated
| return newManifestDesc, nil | ||
| } | ||
|
|
||
| func ReconvertHookFunc() converter.ConvertHookFunc { |
Contributor
There was a problem hiding this comment.
move this func to reconvert_unix.go
pkg/converter/convert_unix.go
Outdated
| } | ||
| } | ||
|
|
||
| func LayerReconvertFunc(opt UnpackOption) ConvertFunc { |
Contributor
There was a problem hiding this comment.
move this func to reconvert_unix.go
J-jxr
force-pushed
the
jxr-pr677-update
branch
2 times, most recently
from
1a2649c to
d21315b
Compare
Signed-off-by: jxr <[email protected]>
J-jxr
force-pushed
the
jxr-pr677-update
branch
from
d21315b to
5e354ba
Compare
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR is an update based on the original PR #677 (submitted by BraveY). It addresses some review comments from the original PR, retains the full commit history , and ensures the core function—reconverting nydus-format images to OCI format—works as expected.
Related Issues
PR#677
Related dragonflyoss/nydus#1682 (follows the same upstream issue as the original PR)
Change Details
Change Type