Skip to content

LWLP-589: upload to s3 on post - #1644

Merged
xbhouse merged 1 commit into
content-services:mainfrom
xbhouse:lwlp-19
Aug 25, 2026
Merged

LWLP-589: upload to s3 on post#1644
xbhouse merged 1 commit into
content-services:mainfrom
xbhouse:lwlp-19

Conversation

@xbhouse

@xbhouse xbhouse commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds support for uploading a provided manifest to S3
  • Adds flag to gate storing uploads

Notes:

  • Task enqueued by the create handler will be added in a follow up

Testing steps

S3 uploads can be tested with the local minio deployment, but a better test would be in stage

Using minio:

  1. Set features.lightwell_store_uploadss: true
  2. Open browser to http://localhost:9002 and create a bucket
  3. Set the bucket name and minio config at clients.lightwell.coverage_uploads:
  lightwell:
    username:
    password:
    coverage_uploads:
      url: http://localhost:9002
      name: lightwell-ui-coverage-uploads
      access_key: minioadmin
      secret_key: minioadmin
      region: us-east-1
  1. POST /coverage_reports/ with a sample manifest file
  2. A row should be inserted in coverage_reports and coverage_uploads and file content uploaded to the minio bucket

@xbhouse
xbhouse force-pushed the lwlp-19 branch 2 times, most recently from 71844ad to 411c702 Compare August 19, 2026 19:55
@xbhouse xbhouse changed the title LWLP-19: create uploads table and report dao with feature flag LWLP-19: add uploads table, upload to s3 on post Aug 19, 2026
@xbhouse
xbhouse force-pushed the lwlp-19 branch 4 times, most recently from bef4b09 to 46b8f3a Compare August 20, 2026 03:26
@xbhouse
xbhouse marked this pull request as ready for review August 20, 2026 03:31
@xbhouse
xbhouse requested a review from a team as a code owner August 20, 2026 03:31
Comment thread configs/config.yaml.example Outdated
Comment thread pkg/handler/coverage_reports.go Outdated
@xbhouse xbhouse changed the title LWLP-19: add uploads table, upload to s3 on post LWLP-589: upload to s3 on post Aug 20, 2026
@xbhouse
xbhouse force-pushed the lwlp-19 branch 7 times, most recently from c8a1f46 to 727ceef Compare August 21, 2026 00:50
TenSt
TenSt previously approved these changes Aug 21, 2026

@TenSt TenSt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@xbhouse

xbhouse commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

/retest

Comment thread deployments/deployment.yaml
@rverdile

Copy link
Copy Markdown
Contributor

/retest

3 similar comments
@rverdile

Copy link
Copy Markdown
Contributor

/retest

@rverdile

Copy link
Copy Markdown
Contributor

/retest

@xbhouse

xbhouse commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@xbhouse
xbhouse force-pushed the lwlp-19 branch 2 times, most recently from 5cfddcd to 102883a Compare August 24, 2026 02:02
rverdile
rverdile previously approved these changes Aug 24, 2026
@xbhouse

xbhouse commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

sorry @rverdile dismissed your review again :) added yet another flag

@xbhouse
xbhouse merged commit e30d848 into content-services:main Aug 25, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants