LWLP-589: upload to s3 on post - #1644
Merged
Merged
Conversation
xbhouse
force-pushed
the
lwlp-19
branch
2 times, most recently
from
August 19, 2026 19:55
71844ad to
411c702
Compare
xbhouse
force-pushed
the
lwlp-19
branch
4 times, most recently
from
August 20, 2026 03:26
bef4b09 to
46b8f3a
Compare
xbhouse
marked this pull request as ready for review
August 20, 2026 03:31
rverdile
reviewed
Aug 20, 2026
rverdile
reviewed
Aug 20, 2026
xbhouse
force-pushed
the
lwlp-19
branch
7 times, most recently
from
August 21, 2026 00:50
c8a1f46 to
727ceef
Compare
Contributor
Author
|
/retest |
rverdile
reviewed
Aug 21, 2026
Contributor
|
/retest |
3 similar comments
Contributor
|
/retest |
Contributor
|
/retest |
Contributor
Author
|
/retest |
xbhouse
force-pushed
the
lwlp-19
branch
2 times, most recently
from
August 24, 2026 02:02
5cfddcd to
102883a
Compare
rverdile
previously approved these changes
Aug 24, 2026
Contributor
Author
|
sorry @rverdile dismissed your review again :) added yet another flag |
rverdile
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notes:
Testing steps
S3 uploads can be tested with the local minio deployment, but a better test would be in stage
Using minio:
features.lightwell_store_uploadss: truehttp://localhost:9002and create a bucketclients.lightwell.coverage_uploads:POST /coverage_reports/with a sample manifest filecoverage_reportsandcoverage_uploadsand file content uploaded to the minio bucket