Merged
Conversation
fixed failed tests
The previous PR #336 partially fixed asset_fields parameters but used incorrect field names. This commit corrects all parameter names to match the CDA API specification. Changes: - Changed 'ai_suggested' to 'ai_generated_metadata' in all test files - Updated SDK documentation to reflect correct parameter names - All asset_fields tests now pass (verified locally) Valid asset_fields[] values per API: - user_defined_fields - embedded_metadata (not 'embedded') - ai_generated_metadata (not 'ai_suggested') - visual_markups API Error that revealed the issue: "Invalid values found, supported values are user_defined_fields, embedded_metadata, ai_generated_metadata, visual_markups" Files Modified: - test/api/asset.spec.ts - test/api/asset-query.spec.ts - test/api/entry.spec.ts - test/api/entries.spec.ts - src/assets/asset.ts (JSDoc) - src/query/asset-query.ts (JSDoc) - src/entries/entry.ts (JSDoc) - src/entries/entries.ts (JSDoc) Test Results: All 16 asset_fields tests passing (8 API + 8 unit)
…rameter-names fix: correct asset_fields[] parameter names for DAM 2.0
back merge
Problem: - The test "should compare initial vs delta sync performance" was failing intermittently due to network variability - Assertion expected deltaTime <= initialTime (strict) - In practice, small syncs (<100ms) have high variance from network latency - Example failure: initialTime=41ms, deltaTime=74ms (both fast, but failed) Solution: - Added hybrid tolerance: max(initialTime * 2, 100ms) - Allows 2x tolerance OR 100ms absolute threshold (whichever is larger) - Accounts for network variability while catching real performance regressions Impact: - Makes test more resilient to network conditions - Still catches meaningful performance degradation - Prevents false negatives from minor timing fluctuations
…ion-tolerance fix: add network tolerance to sync performance assertion
… for includeContentType param
fix: added support for special symbols in regex and added tpe support…
🔒 Security Scan Results
⏱️ SLA Breach Summary
ℹ️ Vulnerabilities Without Available Fixes (Informational Only)The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:
✅ BUILD PASSED - All security checks passed |
Coverage report
Test suite run success654 tests passing in 31 suites. Report generated by 🧪jest coverage report action from 7d2b228 |
back merge
cs-raj
approved these changes
Mar 9, 2026
🔒 Security Scan Results
⏱️ SLA Breach Summary
ℹ️ Vulnerabilities Without Available Fixes (Informational Only)The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:
✅ BUILD PASSED - All security checks passed |
netrajpatel
approved these changes
Mar 9, 2026
cs-raj
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.