Open
Conversation
…ema merging and UID handling; update ContentMapper to support nested modular blocks and prevent duplicate selections fix - CMG-812, CMG-818, CMG-823, CMG-824, CMG-831
…jsdom to 23.2.0, multer to 2.1.1, and rollup to 4.59.0; add overrides for various packages to ensure compatibility Snyk Issue Resolved
Contributor
There was a problem hiding this comment.
Pull request overview
This PR appears to be a bugfix/security-maintenance update across the migration stack, combining dependency updates (including security-driven overrides) with fixes/enhancements to content mapping (notably around nested modular blocks and field-clearing behavior) and schema merge / AEM group processing logic in the API.
Changes:
- Updated dependencies (e.g.,
jsdom,multer) and introduced additionaloverridesto address vulnerable transitive packages. - Enhanced UI ContentMapper logic to support deeper/nested modular-block mapping and to track user-cleared auto-mappings.
- Refactored API content-type merging to recursively merge nested group/block schemas; adjusted AEM group processing source-key handling.
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| upload-api/package.json | Bumps jsdom/multer and adds multiple security-related overrides. |
| upload-api/package-lock.json | Lockfile updates consistent with dependency bumps/overrides. |
| ui/src/components/ContentMapper/index.tsx | Adds cleared-field tracking + nested modular blocks mapping and related selection behavior changes. |
| ui/src/components/ContentMapper/contentMapper.interface.ts | Extends option model with uid to support mapping/selection. |
| ui/package.json | Adds security-related overrides for UI dependencies. |
| ui/package-lock.json | Lockfile updates; pulls newer dependency graph including Node engine constraints. |
| api/src/utils/content-type-creator.utils.ts | Refactors merge logic to recursively merge nested schemas (groups/blocks). |
| api/src/services/aem.service.ts | Adjusts group source-key resolution and group array handling logic. |
Files not reviewed (2)
- ui/package-lock.json: Language not supported
- upload-api/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
…or rollup and overrides in upload-api
umeshmore45
requested changes
Mar 9, 2026
…oved type safety and clarity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.