[16.0][IMP] ignore containers when computing delivery fees#401
Open
mihien wants to merge 1 commit into
Open
Conversation
github-grap-bot
added
mod:container_meals
polchampion
approved these changes
Apr 28, 2026
huguesdk
requested changes
May 8, 2026
Member
There was a problem hiding this comment.
at first, i was surprised that this change touched 34 files and needed 27 commits.
the commit message should use the imperative (as explained here): ”ignore containers for delivery computation”
| @@ -0,0 +1,35 @@ | |||
| # SPDX-FileCopyrightText: 2022 Coop IT Easy SC | |||
Member
There was a problem hiding this comment.
has this really be written in 2022?
| from odoo import http | ||
| from odoo.http import request | ||
|
|
||
| from odoo.addons.website_sale_delivery.controllers.main import WebsiteSaleDelivery |
Member
There was a problem hiding this comment.
should add website_sale_delivery to depends in __manifest__.py.
huguesdk
force-pushed
the
16.0-imp-container_meals
branch
from
5e3720e to
bb01079
Compare
Member
huguesdk
changed the title
ignore containers when computing delivery fees.
huguesdk
force-pushed
the
16.0-imp-container_meals
branch
from
bb01079 to
b9cc7b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Containers are not to be taken into account when computing the delivery costs.
Odoo task (if applicable)
14592
Checklist before approval