MB-60720 - Change the check to determine if rebalance completed#19
Open
metonymic-smokey wants to merge 1 commit intocouchbase:trinityfrom
Open
MB-60720 - Change the check to determine if rebalance completed#19metonymic-smokey wants to merge 1 commit intocouchbase:trinityfrom
metonymic-smokey wants to merge 1 commit intocouchbase:trinityfrom
Conversation
metonymic-smokey
force-pushed
the
trinity
branch
from
3274b6c to
fdc9c1d
Compare
metonymic-smokey
changed the title
Contributor
Author
|
@abhinavdangeti pls take a look |
Member
|
No this is not right - lastRebStatus being NoRecord or RebCompleted is good. So I don't think we should be making this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the check around checking if rebalance is completed by checking for completion instead of starting.