Conversation
Contributor
|
Thanks for the contribution @adasari, this looks like a reasonable change. We need to make sure all SDKs are aligned on this, so it's added to the specification and then we can add this. We'll get back to you when that's done. |
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IoConfig.EnableTCPNoDelayto configureTCP_NODELAYon KV connections.TCP_NODELAYremains disabled unless explicitly enabled.Motivation
gocbcore currently calls
SetNoDelay(false)for every KV connection without providing a way for applications to override it.The Java Couchbase client uses Netty, whose
DefaultSocketChannelConfigenablesTCP_NODELAYby default when supported. A controlled benchmark using bursts of 10 concurrent missing-key GETs showed a significant difference:TCP_NODELAY=falseTCP_NODELAY=trueExposing this setting allows latency-sensitive applications to opt into the same socket behavior without changing the default for existing users.
Testing Done
go test ./...suite passesTCP_NODELAYvalue for both enabled and disabled configurations