Skip to content

feat(api-client): 添加 CreateChatReq 类的自定义参数属性#97

Closed
Mibloom wants to merge 1 commit into
coze-dev:mainfrom
Mibloom:add-parameters
Closed

feat(api-client): 添加 CreateChatReq 类的自定义参数属性#97
Mibloom wants to merge 1 commit into
coze-dev:mainfrom
Mibloom:add-parameters

Conversation

@Mibloom

@Mibloom Mibloom commented May 19, 2025

Copy link
Copy Markdown
Contributor
  • 在 CreateChatReq 类中添加了 parameters 属性,用于自定义参数
  • 使用 Map<String, Object> 类型以支持多种类型的自定义参数
  • 通过 JSON 注解@JsonProperty("parameters")进行序列化和反序列化

@coderabbitai

coderabbitai Bot commented May 19, 2025

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

Walkthrough

A new field named parameters of type Map<String, Object> was added to the CreateChatReq class. This field allows the inclusion of flexible, customized key-value pairs with arbitrary object values, and is annotated for JSON serialization. No other fields or methods were changed.

Changes

File(s) Change Summary
api/src/main/java/com/coze/openapi/client/chat/CreateChatReq.java Added a parameters field (Map<String, Object>) with JSON annotation to CreateChatReq.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant CreateChatReq
    participant API

    Client->>CreateChatReq: Instantiate with parameters map
    CreateChatReq->>API: Send request with parameters as JSON
    API-->>CreateChatReq: Process response
    CreateChatReq-->>Client: Return API response
Loading

Poem

A field named "parameters" hops in with glee,
Carrying objects, as flexible as can be.
Now chats can be custom, with values so wide,
In a map they all nestle, side by side.
A rabbit approves, with a twitch of its nose—
More options for chats, as the feature list grows!
🐇✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 71b9b92 and 3a7a9c1.

📒 Files selected for processing (1)
  • api/src/main/java/com/coze/openapi/client/chat/CreateChatReq.java (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
api/src/main/java/com/coze/openapi/client/chat/CreateChatReq.java (1)

74-79: Field implementation looks good but consider clarifying documentation

The implementation of the new parameters field is appropriate for allowing custom parameters with flexible value types. However, the current documentation is quite brief.

Consider enhancing the documentation to:

  1. Clarify the purpose of this field
  2. Explain how it differs from the existing customVariables field (which only accepts String values)
  3. Provide an example usage scenario
  /*
-  * The customized parameters
+  * Holds customized parameters as key-value pairs where values can be of any type.
+  * Unlike 'customVariables' which only accepts String values, this field supports arbitrary objects.
+  * Example usage: parameters.put("temperature", 0.7); parameters.put("options", someComplexObject);
   * */
  @JsonProperty("parameters")
  private Map<String, Object> parameters;
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between fc03b09 and 71b9b92.

📒 Files selected for processing (1)
  • api/src/main/java/com/coze/openapi/client/chat/CreateChatReq.java (1 hunks)
🧰 Additional context used
🪛 GitHub Actions: CI
api/src/main/java/com/coze/openapi/client/chat/CreateChatReq.java

[error] 77-83: Spotless formatting check failed. The file has format violations. Run 'mvn spotless:apply' to fix these violations.

@JsonProperty("parameters")
private Map<String, Object> parameters;


Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Remove extra blank line

There's an extra blank line here that's likely causing the Spotless formatting check to fail. The CI pipeline has reported a formatting issue in this file.

  @JsonProperty("parameters")
  private Map<String, Object> parameters;
-

Please run mvn spotless:apply as mentioned in the pipeline failure to automatically fix this and any other formatting issues.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
@JsonProperty("parameters")
private Map<String, Object> parameters;
🤖 Prompt for AI Agents
In api/src/main/java/com/coze/openapi/client/chat/CreateChatReq.java at line 80,
there is an extra blank line causing the Spotless formatting check to fail.
Remove this extra blank line and then run the command `mvn spotless:apply` to
automatically fix this and any other formatting issues in the file.

- 在 CreateChatReq 类中添加了 parameters 属性,用于自定义参数
- 使用 Map<String, Object> 类型以支持多种类型的自定义参数
- 通过 JSON 注解@JsonProperty("parameters")进行序列化和反序列化
@Mibloom Mibloom closed this May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant