-
Notifications
You must be signed in to change notification settings - Fork 804
Don't define typedef-names in the library wording #6419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't define typedef-names in the library wording #6419
Conversation
46aa0dc to
ed407e0
Compare
ed407e0 to
dd1a092
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
I'm very much on board with replacing "defined" with "declared" when we're talking about the introduction of a name, such as "X is declared if and only if..." I think that's a straightforward fix and actually improves the presentation quite a bit. For situations where we describe what the "value" of a typedef is, I like "defined" a bit better, because it's alluding to the mathematical idea of "definition", and that's what we do in those contexts. A better way of phrasing this without using the term "defined" might exist, but "determined" leaves open a bit who determines what. Maybe "specified to be" would work; I'm not sure. Anyway, if you want to extract the changes of the first category into a separate pull request, where we actually talk about the (presence of) a typedef declaration, then that could probably progress faster. |
dd1a092 to
9bab345
Compare
|
@jensmaurer Now the changes to "determined" are reverted. |
9bab345 to
ddd5f43
Compare
0e8ef31 to
6fb7a92
Compare
|
Rebased & force-pushed. @tkoeppe @jensmaurer |
6fb7a92 to
322b79c
Compare
|
I would love to see this clean-up considered for the C++26 FDIS, but first it needs a rebase! |
I rebased the changes many times to resolve conflicts. But the label hasn't been removed for a long while. |
322b79c to
41b9a54
Compare
|
@jwakely , this concerns library wording. |
41b9a54 to
007409a
Compare
49306d6 to
3f94d9e
Compare
|
On Dec 15, 2025, at 8:02 AM, Jens Maurer ***@***.***> wrote:
@jensmaurer commented on this pull request.
In source/lib-intro.tex <#6419 (comment)>:
> @@ -528,8 +528,8 @@
\pnum
Several entities
-defined in \ref{\firstlibchapter} through \ref{\lastlibchapter} and \ref{depr}
-are only defined for the purpose of exposition.
+declared in \ref{\firstlibchapter} through \ref{\lastlibchapter} and \ref{depr}
+are only declared for the purpose of exposition.
Each definition is also a declaration, so "declared" alone is enough.
But the "only" should be after the "declared".
I believe the phrase "the purpose of" is unnecessary. Instead, I recommend "...are declared for exposition only."
Further, I doubt we need to repeat "declared"; instead, I recommend "are provided for exposition only."
|
Also use "provided for exposition only" from @W-E-Brown's suggestion.
Also mention [re].
In the example, it seems a bit verbose to say "declarations and definitions".
Use "declare" instead.
Use "declare" instead.
Use declared" instead.
Use "declare" instead.
Use "declare" instead.
Use "declare" instead.
Use "declare" instead.
Use "declare" instead.
Use "declare" instead.
Use "declare" instead.
3f94d9e to
f2aa185
Compare
Since typedef-names are declared but not defined ([basic.def]/2.9, [basic.def]/2.10).
value_type(or sometimestype?) is not always a typedef-name, but it is in most case. So, I'm changing to use "declared" for it.iterator_categoryanditerator_concept, this PR used to use "determined" instead of "defined" when the aliased type is talked. Now the changes to "determined" are reverted.