Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
SAY-5
force-pushed
the
fix-glob-braces-curlies
branch
from
July 20, 2026 07:17
64af1ca to
c4ffbd6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #248.
curlies = 0, escaping = falseon line 16 ofutils/glob.rbwas parsed ascurlies = [0, false], socurliesended up an Array and any pattern with a brace crashed atcurlies += 1/curlies.positive?. Split it into two assignments. Thereturnstatements inside thechars.mapblock also returned from the whole method instead of the block, so I changed them tonext. Addedtest/test_glob.rbcovering brace expansion, an unmatched}, and an escaped char.