Skip to content

ADR 004: Promote Src/java to repository root and other changes#1797

Merged
JPercival merged 10 commits into
mainfrom
adr-004-pt-2
Jul 8, 2026
Merged

ADR 004: Promote Src/java to repository root and other changes#1797
JPercival merged 10 commits into
mainfrom
adr-004-pt-2

Conversation

@antvaset

@antvaset antvaset commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

The second step of ADR 004:

  • Move Src/cql-lm/schema to schemas
  • Move Src/cql-lm/uml to schemas/uml
  • Move Src/grammar to grammar
  • Move Src/java/* to repository root
    • Merge Src/java/.vscode/settings.json into existing .vscode/settings.json in the repository root
    • Merge Src/java/README.md into existing README.md in the repository root
  • Move Src/js to js
  • Move Examples toexamples
  • Update relative paths that relied on the old directory structure
  • Update the broken Maven Central badge in the main README.md along the way and add the npm package badge

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

Related Issues

The following open issues may be related to this PR:

Issue Title Score Matched Terms
#1365 Deprecate SearchInfo.type element 40 "com cqframework", "cqframework clinical", "src cql", "https github", "language blob", "github com", "cql schema", "quality language", "clinical quality", language, cqframework, github, src, quality, schema, json, com, blob, schemas, https, cql, clinical
#455 Ratio Literal Can't Reference Quantity Expression Values 38 "com cqframework", "cqframework clinical", "src cql", "https github", "language blob", "github com", "cql schema", "quality language", "clinical quality", language, cqframework, github, src, quality, schema, com, blob, https, cql, clinical
#1287 Revisit CQL Engine and Result APIs 38 "src java", "com cqframework", "cqframework clinical", "https github", "language blob", "github com", "quality language", "clinical quality", step, language, cqframework, github, java, along, src, quality, com, blob, main, https, cql, clinical
#765 Cql-to-elm Jackson dependency: Move CqlTranslatorOptionsMapper to a module? 37 "src java", "com cqframework", "cqframework clinical", "https github", "language blob", "github com", "quality language", "clinical quality", language, cqframework, github, java, src, quality, com, blob, move, main, https, cql, clinical
#1700 Loading libraries from intermediary forms 37 "src java", "com cqframework", "cqframework clinical", "https github", "github com", "main src", "quality language", "clinical quality", language, cqframework, github, examples, java, src, quality, json, com, main, https, cql, clinical

Tip: If this PR addresses any of these issues, please link them using Closes #NNN or Refs #NNN in the PR description.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

Formatting check succeeded!

@antvaset antvaset changed the title ADR 004: Promote Src/java to repository root ADR 004: Promote Src/java to repository root and other changes Jul 8, 2026
@antvaset antvaset changed the title ADR 004: Promote Src/java to repository root and other changes ADR 004: Promote Src/java to repository root and other changes Jul 8, 2026
@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.75%. Comparing base (a266278) to head (f5ff261).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1797   +/-   ##
=========================================
  Coverage     68.75%   68.75%           
  Complexity     1699     1699           
=========================================
  Files           536      536           
  Lines         30559    30559           
  Branches       6988     6988           
=========================================
  Hits          21011    21011           
  Misses         6994     6994           
  Partials       2554     2554           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@c-schuler c-schuler left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of possible broken links in README.

Also noticed some references to previous Src/... paths in ExampleELMLibrary.xml and v4-to-v5-migration.md.

No blocking issues though.

Nice work!

Comment thread README.md Outdated
Comment thread README.md Outdated
@JPercival JPercival enabled auto-merge (squash) July 8, 2026 22:16
@antvaset

antvaset commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @c-schuler and @JPercival I've fixed the Src/... references in the example XML libraries and migration docs.

@sonarqubecloud

sonarqubecloud Bot commented Jul 8, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
66.5% Coverage on New Code (required ≥ 80%)
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@JPercival JPercival merged commit 95366e9 into main Jul 8, 2026
9 of 10 checks passed
@JPercival JPercival deleted the adr-004-pt-2 branch July 8, 2026 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants