Skip to content

Conversation

@heitorado
Copy link
Contributor

@heitorado heitorado commented Dec 18, 2025

related to #4120, #4119

This PR:

  • Adds a new event, FlowFailedEvent
  • Emits the FlowFailedEvent on an except block which will be executed if any exceptions bubble up to the kickoff flow method
  • Add listener to FlowFailedEvent that will wrap up and finalise the trace batch
  • Remove redundant type parameters from emit call since those are already defined in the model
  • Move batch finalisation on flow finished to the FlowFinishedEvent listener so we rely on the event bus to finalise the batch rather than the kickoff method body.

towards ENG-718

@linear
Copy link

linear bot commented Dec 18, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants