feat(Twitter): Add Dynamic color switch toggle - #1582
Conversation
75be758 to
4366a59
Compare
3b8db4f to
08ffff9
Compare
|
I priority fixes over this. Will include on the next one |
|
This patch uses a custom app icon patch, but afaik there is a bug with custom app icons in the recent version of X. Won't this issue occur by dynamic color toggle also changing the app icon? |
36abcdf to
b660f69
Compare
| ), | ||
| ), | ||
| custom = { methodDef, _ -> | ||
| AccessFlags.STATIC.isSet(methodDef.accessFlags) && |
There was a problem hiding this comment.
I guess you can add access flags as separate parameters which accepts a list.
There was a problem hiding this comment.
The accessFlags parameter performs an exact comparison with method.accessFlags, while the target method may have additional flags. the custom predicate intentionally checks only whether STATIC is present. it is also needed to express the non-static condition for ComponentFactoryActivityFingerprint
| name = "Dynamic color", | ||
| description = "Adds an option to replace Twitter Blue with the user's Material You palette.", | ||
| default = false, | ||
| default = true, |
There was a problem hiding this comment.
Set the default to false, many may not want this by default
There was a problem hiding this comment.
Since this patch no longer makes permanent resource changes, it can be default
Just like many other patches those have a toggle in Piko settings
|
I fixed change custom icon patch in #1624 But rather than linking the app icon to the dynamic color toggle, I think it would be better to add it as a new option to the existing “Change app icon” patch. Reason:
If you adopt this approach, I think a guidance for changing app icon can be added to the summary of the toggle. |
## [3.9.0-dev.3](v3.9.0-dev.2...v3.9.0-dev.3) (2026-08-03) ### 🐛 Bug Fixes * **Instagram:** Check and add external downloader options in settings ([c6651df](c6651df)) * **instagram:** patch GRAY_1600 to fix Compose surfaces staying gray in AMOLED mode ([#1596](#1596)) ([07d08d4](07d08d4)) * **Twitter:** "Change app icon" is broken on recent X versions ([#1624](#1624)) ([350779d](350779d)) * **Twitter:** Fix check and add `more info on profile` preference ([97f9dca](97f9dca)) * **twitter:** replace ic_vector_x logo in Bring back twitter patch ([7b6c7e9](7b6c7e9)) ### ✨ New Features * **instagram:** add material you and amoled theme controls ([#1631](#1631)) ([840492a](840492a)) * **Instagram:** Added `Recommended flags` section ([ff31eda](ff31eda)) * **Instagram:** Added more options in profile options menu ([#1638](#1638)) ([ad61869](ad61869)) * **Twitter:** Add Dynamic color switch toggle ([#1582](#1582)) ([c3de8d8](c3de8d8))
Adds a dynamic color switch under customize. also fixes the following issues:
Testing
.\gradlew.bat :extensions:twitter:compileDebugSources :patches:compileKotlin :patches:checkStringResources --console=plainCloses #1588