fix(instagram): pass current carousel index to reel overflow buttons

[kuntal-devrat]

Problem

When a reel post contains multiple images (carousel/slideshow), tapping the download button or any other overflow menu button (external downloader, more options) always operated on slide 1, regardless of which slide the user was currently viewing. The index was hardcoded to 0 in all ReelButton subclasses.

Root Cause

The reel overflow button hook (ClipsOrganicMediaItemViewMoreOptionsController) did not pass the current carousel position to the extension. No index was read from the controller at hook time.

Fix

The hook now reads CURRENT_MEDIA_FIELD from MEDIA_ADD_INFO_CLASS_NAME on the controller class — the same field and pattern already used by the feed onClick hook (HookOverflowMenuButtonOnClickPatch).

A safe three-instruction register sequence is used to avoid clobbering live registers (which caused a previous crash):

iget-object freeReg, self, mediaExtraDataField    ← read extra-data obj (self still intact)
iget        freeReg, freeReg, CURRENT_MEDIA_FIELD ← read int index (safe reuse of freeReg)
iget-object self,    self,    appActivityField    ← clobber self LAST, after all reads done

Falls back to index 0 via a 3-arg overload if mediaExtraDataField is not found on the controller class.

hookReelOverflowMenuButton now depends on decoderEntity to ensure CURRENT_MEDIA_FIELD and MEDIA_ADD_INFO_CLASS_NAME are resolved before the hook runs.

Testing

Confirmed on a real device — downloading from slide 3 of a carousel reel correctly downloads slide 3. Single-video reels and the reel overflow bottom sheet are unaffected.

Note

The consent popup fix (#1574, #1563) is handled separately in PR #1585 which introduces a dedicated Disable onboarding permission prompts patch.

Closes #1562

[kuntal-devrat]

Addressed — removed the unused 2-parameter constructors from all button subclasses (DownloadButton, ExternalDownloadButton, InfoButton, DebugButton) and from the base ReelButton class. Force pushed.

its good to go

[kuntal-devrat]

Addressed all three comments:

1. DebugButton — reverted to 2-param constructor with hardcoded index 0, since it doesn't use the index.
2. Fallback else branch — removed. The controller class confirmed to always have the \MEDIA_ADD_INFO_CLASS_NAME\ field (tested on device). The fallback was dead code.
3. Removed the now-unused 3-arg \includeCustomReelOverflowButtons\ overload from \AddReelButton\ as well.

Force pushed.

[swakwork]

Just noticed MEDIA_ADD_INFO_CLASS_NAME isn't present in the Add Reels Button class

[kuntal-devrat]

Just noticed MEDIA_ADD_INFO_CLASS_NAME isn't present in the Add Reels Button class

My bad 😔 and I saw that you fixed that.

I will be more careful from now on 😅

Actually I'm new into this....so please