Repository navigation
Units preference; Measure shows mm or inches (#234) - #244
Merged
Merged
Conversation
The Measure plugin printed sizes and volume in bare scene units, which meant nothing to someone preparing a print. Add a Units preference (metric or imperial) and the size of a scene unit in millimetres, the same scale the 3D print window already used, now saved with the settings. Plugin API 5 exposes both (units(), unit_scale()), and Measure uses them: mm and cm³, or inches and in³. Its number formatting now uses 64-bit integers, so large models in small units don't overflow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GEttLK8THCkZ7KHELbSp7g Signed-off-by: Claude <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com> # Conflicts: # docs/ROADMAP.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #234: the Measure plugin now shows units.
What changes
units() -> i32: 0 metric, 1 imperial.unit_scale() -> f32: millimetres per scene unit, never 0.Verified
cargo fmt --check,clippy -D warnings,cargo test --workspace,check_corpus_ip.py.units(), andunit_scale()falls back to 1 for a zero scale.Not done
Generated by Claude Code