Conversation
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
6fe554e to
4af9c39
Compare
|
Actually, this can lose changes that were made before calling the finalizer code, i.e. there is no way around comparing to a fresh object :-/ |
|
Crossplane does not currently have enough maintainers to address every issue and pull request. This pull request has been automatically marked as |
|
Crossplane does not currently have enough maintainers to address every issue and pull request. This pull request has been automatically marked as |
Description of your changes
Calling
Updateon a non-unstructured object will potentially lead to data-loss because it is not guaranteed that the object is a complete representation of all the fields stored in the apiserver, e.g. because of version skew between client and Crossplane.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Via Crossplane test suite, aka unit tests and e2e tests.