Allow Symfony v8 components#218
Merged
Merged
Conversation
* Component `symfony/css-selector` has zero breaking changes * Component `symfony/dom-crawler` only has one irrelevant breaking change from code point of view, see symfony/symfony#61475 - not sure about behavior tho see https://github.com/symfony/symfony/blob/8.1/UPGRADE-8.0.md
Member
|
Hey @chr-hertel, |
Member
|
Hey @chr-hertel, thx again, I just released it with https://github.com/crwlrsoft/crawler/releases/tag/v3.5.7 Also the upgrade in the schema-org package with https://github.com/crwlrsoft/schema-org/releases/tag/v0.4.0 - I used the fact that it's still 0.x to just drop support for PHP 8.0 and 8.1 as well as for symfony/dom-crawler 6.x. |
Contributor
Author
|
Awesome, thanks for the fast follow-up @otsch - really appreciated! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes of Symfony 8
symfony/css-selectorhas zero breaking changessymfony/dom-crawleronly has one irrelevant breaking change from code point of view, see [DomCrawler] Use the native HTML5 parser on PHP 8.4 symfony/symfony#61475 - not sure about behavior thosee https://github.com/symfony/symfony/blob/8.1/UPGRADE-8.0.md