Skip to content

fix(versiondb): ignore non-leaf nodes data in restore-versiondb cli command#2065

Merged
randy-cro merged 6 commits into
crypto-org-chain:mainfrom
randy-cro:fix/versiondb
May 18, 2026
Merged

fix(versiondb): ignore non-leaf nodes data in restore-versiondb cli command#2065
randy-cro merged 6 commits into
crypto-org-chain:mainfrom
randy-cro:fix/versiondb

Conversation

@randy-cro
Copy link
Copy Markdown
Contributor

@randy-cro randy-cro commented May 15, 2026

cronos-store PR: crypto-org-chain/cronos-store#55

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

  • Bug Fixes

    • The restore-versiondb command now ignores non-leaf node data during restore, improving restore reliability and efficiency.
  • Dependencies

    • Updated core storage and versioning components to newer releases for improved stability and performance.

Review Change Stack

@randy-cro randy-cro requested a review from a team as a code owner May 15, 2026 10:12
@randy-cro randy-cro requested review from calvinaco and songgaoye and removed request for a team May 15, 2026 10:12
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5ff82ce7-3bef-400d-b77d-13a54e7c7143

📥 Commits

Reviewing files that changed from the base of the PR and between edcec8d and b062515.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (3)
  • CHANGELOG.md
  • go.mod
  • gomod2nix.toml
✅ Files skipped from review due to trivial changes (2)
  • CHANGELOG.md
  • gomod2nix.toml
🚧 Files skipped from review as they are similar to previous changes (1)
  • go.mod

📝 Walkthrough

Walkthrough

Bumps cronos-store submodules to a newer commit that contains a versiondb CLI bug fix, adds a changelog entry for the fix, and updates gomod2nix pins to match.

Changes

versiondb Bug Fix and Dependency Update

Layer / File(s) Summary
Changelog Entry
CHANGELOG.md
New UNRELEASED bug-fix entry for PR #2065 documents that restore-versiondb CLI now ignores non-leaf nodes data.
Go Module Version Updates
go.mod
github.com/crypto-org-chain/cronos-store submodules (store, versiondb, memiavl) pinned to v0.0.0-20260518071248-f0453c15e437 in require and replace sections.
Nix Dependency Pins Synchronization
gomod2nix.toml
Pinned version entries for memiavl, store, and versiondb updated to v0.0.0-20260518071248-f0453c15e437; versiondb hash updated.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

backport/v1.4.x

Suggested reviewers

  • calvinaco
  • mmsqe

🐰
I hopped through modules, pins aligned,
A changelog leaf where bugs resigned,
Version bumps snug, hashes set just so,
Restore now skips what shouldn't grow,
Tiny paws clap for tidy flow.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: fixing the restore-versiondb CLI command to ignore non-leaf nodes data, which aligns with the PR's stated objective and the dependency update to cronos-store that implements this fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@socket-security
Copy link
Copy Markdown

socket-security Bot commented May 15, 2026

@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 28.25%. Comparing base (a3c2f70) to head (b062515).
⚠️ Report is 191 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2065       +/-   ##
===========================================
+ Coverage   16.87%   28.25%   +11.38%     
===========================================
  Files          72       78        +6     
  Lines        6163     5238      -925     
===========================================
+ Hits         1040     1480      +440     
+ Misses       5000     3582     -1418     
- Partials      123      176       +53     

see 72 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@go.mod`:
- Around line 27-28: The go.mod update pins cronos-store and versiondb to an
unmerged commit (302fa637a345) that doesn't match PR `#55`; revert these
dependency lines to the last known good released version or remove the two
entries, and either wait for PR `#55` to be merged and then update to the correct
commit/tag or replace 302fa637a345 with the verified commit hash or release that
contains the intended versiondb CLI fix; specifically update the entries
referencing github.com/crypto-org-chain/cronos-store/store and
github.com/crypto-org-chain/cronos-store/versiondb to a released tag or the
correct commit after PR `#55` is merged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a99b7073-1cf2-4b6b-90b2-646df276b6cb

📥 Commits

Reviewing files that changed from the base of the PR and between e42d284 and edcec8d.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (3)
  • CHANGELOG.md
  • go.mod
  • gomod2nix.toml

Comment thread go.mod Outdated
@randy-cro randy-cro enabled auto-merge May 18, 2026 07:22
@randy-cro randy-cro added this pull request to the merge queue May 18, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 18, 2026
@randy-cro randy-cro added this pull request to the merge queue May 18, 2026
Merged via the queue into crypto-org-chain:main with commit d61fd70 May 18, 2026
64 of 67 checks passed
@randy-cro randy-cro deleted the fix/versiondb branch May 18, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants