Skip to content

ci: build what we ship, not just what type-checks #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chiliec merged 1 commit into from
Sep 9, 2026
Merged

ci: build what we ship, not just what type-checks #311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,10 @@ jobs:
- run: npm --prefix src/frontend ci
- run: npm run lint
- run: npm run typecheck
- run: npm --prefix src/frontend run build
# typecheck is `tsc` with noEmit, so it never exercises the emit that
# `build:bot` actually ships, and the landing build was not run at all.
# build:all covers both plus the frontend build this step used to do.
- run: npm run build:all

backend-tests:
runs-on: ubuntu-latest
Expand Down