Skip to content

Make subscribe callbacks optional in typings#548

Open
vlinder wants to merge 2 commits intocujojs:masterfrom
vlinder:make-subscribe-callbacks-optional
Open

Make subscribe callbacks optional in typings#548
vlinder wants to merge 2 commits intocujojs:masterfrom
vlinder:make-subscribe-callbacks-optional

Conversation

@vlinder
Copy link

@vlinder vlinder commented Jan 21, 2021

Summary

Update docs and typescript typings to reflect that methods on the Observer all are optional.

Here is what is linked in the docs regarding the Observer: https://github.com/tc39/proposal-observable#observer

Flow types seem to be correct already.

most/src/index.js.flow

Lines 50 to 55 in bfed148

export type Subscriber<A> = {
+next?: (value: A) => void;
+error?: (err: Error) => void;
// complete value parameter is deprecated
+complete?: (value?: A) => void;
}

Todo

  • Unit tests for new or changed APIs and/or functionality
  • Documentation, including examples

According do the documentation All callbacks on the Observer interface are optional.
@vlinder vlinder changed the title Make subscribe callbacks optional Make subscribe callbacks optional in typings Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant