fix: add aarch64-linux closure to bento.nix - #97
Conversation
CI agents run linux_arm64; bento was darwin-only, so devbox install failed on every repo that references devbox-extras#bento (lde-kafka-sink, delivery-eng-experiments/011-2-bento-sink) under patch-cves. FEF-3164
🤖 Agent Workflows
|
![pip-the-concierge-via-chinmina[bot]](https://avatars.githubusercontent.com/in/897802?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
Clean, well-structured PR that adds aarch64-linux platform support to bento.nix, fixing CI failures on ARM64 Linux agents. The new closure follows the identical pattern as the existing Darwin closures (same stdenv.mkDerivation + fetchzip + pinned SRI hash approach), and meta.platforms is correctly extended. No issues found.
For reviewers
Straightforward change — the new aarch64-linux branch at line 44 mirrors the existing Darwin closures exactly. Key things to verify: the SRI hash matches the upstream release asset (author confirmed via local nix-build), and the URL follows the established bento_${version}_linux_arm64.tar.gz naming convention.
1 Low-signal findings hidden
click to expand
packages/bento.nix: README not updated for new platform support — rejected because the README has no per-package platform documentation for any existing package, so this would create a new convention rather than follow one.
generated using the pr-review workflow in 16 turns
give feedback with reactions 👍 👎
1 participant
Summary
bento.nixonly handledx86_64-darwin/aarch64-darwin; every Linux system hitabort "unsupported system".agent-workflowspatch-cves runlinux_arm64, sodevbox installfails on every run for repos referencinggithub:cultureamp/devbox-extras#bento(lde-kafka-sink, and soondelivery-eng-experiments/011-2-bento-sink).aarch64-linuxclosure using the upstreambento_1.4.0_linux_arm64.tar.gzrelease asset. Verified withnix-buildlocally.Test plan
nix-build -E '... import ./packages/bento.nix { system = "aarch64-linux"; ... }'builds successfully with the new hashnix run nixpkgs#nixpkgs-fmt -- packages/bento.nixreports no changes neededJira: FEF-3164