Skip to content

WP-10863 - Standardize Button Size Control in all blocks#814

Open
NikhilSHarma8429 wants to merge 5 commits into
cyberchimps:developfrom
NikhilSHarma8429:Standarize-buttons
Open

WP-10863 - Standardize Button Size Control in all blocks#814
NikhilSHarma8429 wants to merge 5 commits into
cyberchimps:developfrom
NikhilSHarma8429:Standarize-buttons

Conversation

@NikhilSHarma8429

Copy link
Copy Markdown
Contributor

PR Request Template

Common Checks

  • No PHPCS issues related to the files in the PR
  • Self-testing is done
  • Appropriate comments are added in the code
  • There are no error_log statements
  • There are no unnecessary console log statements
  • Changelog is updated if required
  • Version no is updated if required
  • All best practices are followed, and code doesn't contain any deprecated code/methods
  • There are no console errors due to your code

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I've used !important here only because the existing CSS for the desktop view already included !important in all its rules. Removing those might break the UI in some scenarios, so I decided not to. Without adding !important for the tablet and mobile views, the desktop CSS would always override them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant