Added on close#29
Open
bjacog wants to merge 2 commits into
Open
Conversation
Proberts
pushed a commit
to Proberts/react-native-modal-picker
that referenced
this pull request
Apr 13, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added the ability to pass a function that runs when the modal is hidden. This is usefull for having navigation happen on item select that does not play well with onChange as the navigation is fired before the modal is closed and the reference to the modal could be lost eventhough it is still rendered on the screen. Moving navigation code to onClose solved this problem for me.