Use flex to automatically size optionContainer to its contents.#37
Open
peacechen wants to merge 129 commits into
Open
Use flex to automatically size optionContainer to its contents.#37peacechen wants to merge 129 commits into
peacechen wants to merge 129 commits into
Conversation
overlayStyle and cancelContainer adjusted accordingly to dynamically center content in a generic fashion.
|
merged into my fork |
Author
|
Thanks @fabriziomoscon. Do you publish your fork to NPM? I noticed that you also removed flex:1 from selectStyle for RN 0.39 compatibility: I haven't tested against 0.39, but if you've vetted it I'll add that change to my PR. |
|
At the moment my I am not planning to republish it under a different name. Yes I tested it with RN 0.39.2 on android |
- versions of react native < 0.39.0 should pass flex:1 explicitly to selectStyle as a prop. - Update Readme to reflect selectStyle prop change for RN 0.39.
Proberts
pushed a commit
to Proberts/react-native-modal-picker
that referenced
this pull request
Apr 13, 2017
|
Is there an update on getting this merged? In need of this functionality but would like to use the original repo. |
|
This repo is abandoned, I have cheery picked few PR from here in my fork since I am using this code in production. |
Fixes sizing when rotating between landscape & portrait orientations.
* Prop to change supported orientation
* add base eslint rules and fix lint errors * add arbitrary eslint rules - key-spacing - no-empty-functions - comma-dangle rules to prevent runtime errors
Backwards compatible with RN pre-0.44.
* add support for configurable animationType * updated documentation
Update bitmap link and improve sample code.
See #168 for description of error
* add option param to onModalClose type * export props
* update 1) updated expo version of sample app to 40.0.0 2) added typescript to sample app 3) converted sample app.tsx from class component to functional 4) fixed types issue * added more types
Co-authored-by: Arthur Arakelyan <artur.araqelyan.2004@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the modal contents to automatically fit any screen.