-
Notifications
You must be signed in to change notification settings - Fork 0
changelog: add entries for deployment tools #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -281,4 +281,49 @@ All notable changes to this project will be documented in this file. | |||||
|
|
||||||
| --- | ||||||
|
|
||||||
| ## [Unreleased] - 2025-08-07 | ||||||
|
|
||||||
| ### Added | ||||||
| - **Custom Model Deployment Solution** - Complete pipeline to upload custom-trained models to HuggingFace Hub for production deployment | ||||||
| - Created `scripts/deployment/upload_model_to_huggingface.py` - Comprehensive script to find, prepare, and upload custom trained models | ||||||
| - Added `deployment/CUSTOM_MODEL_DEPLOYMENT_GUIDE.md` - Complete guide for deploying custom models with multiple deployment strategies | ||||||
| - Added `deployment/flexible_api_server.py` - Flexible API server supporting serverless, endpoints, and self-hosted deployments | ||||||
|
Comment on lines
+288
to
+290
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This changelog entry appears to document a set of features and files that are not included in this pull request or the current branch. The following files mentioned in the
This discrepancy makes the changelog inaccurate and could cause significant confusion for anyone reading the release notes. Please ensure the changelog accurately reflects the changes being introduced in the codebase. |
||||||
| - **Portable Configuration**: Environment variable support (`SAMO_DL_BASE_DIR` or `MODEL_BASE_DIR`) with automatic project root detection | ||||||
| - Added `deployment/models/` directory with README for organized model storage | ||||||
| - Created `.env.model_config.example` template for easy environment configuration | ||||||
| - **HuggingFace Deployment Strategies**: | ||||||
| - 🆓 Serverless Inference API (free tier with rate limits) | ||||||
|
||||||
| - 🆓 Serverless Inference API (free tier with rate limits) | |
| - [FREE] Serverless Inference API (free tier with rate limits) |
Copilot
AI
Aug 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Using emoji characters in changelog entries may cause display issues in certain environments or when the changelog is processed by automated tools. Consider using plain text alternatives like '[PAID]' or '(Production)' instead of '🚀'.
| - 🚀 Inference Endpoints (paid, production-grade with consistent latency) | |
| - [PAID] Inference Endpoints (paid, production-grade with consistent latency) |
Copilot
AI
Aug 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Using emoji characters in changelog entries may cause display issues in certain environments or when the changelog is processed by automated tools. Consider using plain text alternatives like '[SELF-HOSTED]' or '(Local)' instead of '🏠'.
| - 🏠 Self-hosted (maximum control with local transformers) | |
| - [SELF-HOSTED] Self-hosted (maximum control with local transformers) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the detail provided in this changelog entry is comprehensive, it might be overly verbose for a high-level changelog, especially the 'Automated Features' and 'Technical Details' sections. Consider summarizing the key features and linking to the new CUSTOM_MODEL_DEPLOYMENT_GUIDE.md or other technical documentation for the full details. This would make the main changelog more scannable for users.
A more concise entry might look like:
### Added
- **Custom Model Deployment Solution**: Added a complete pipeline to upload and deploy custom-trained models to HuggingFace Hub. This includes scripts for uploading, a flexible API server, and comprehensive documentation. See `deployment/CUSTOM_MODEL_DEPLOYMENT_GUIDE.md` for full details on deployment strategies (Serverless, Endpoints, Self-hosted) and automated features.
### Fixed
- **Model-as-a-Service Configuration Issue**: Resolved an issue where deployments incorrectly used untrained base models instead of custom-trained ones.
### Changed
- The deployment infrastructure now supports custom models from HuggingFace Hub.
- Model loading configuration updated to use 12 custom emotion classes.The 'Technical Details' section could be moved to the relevant guide or design document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The date '2025-08-07' in the Unreleased section is inconsistent with changelog conventions. Unreleased sections typically don't include specific dates since they represent pending changes. Consider using just '## [Unreleased]' or move this to a versioned release when ready.