Skip to content

Fix asymmetric loss gradient disconnection - #3

Draft
d-ulker wants to merge 3 commits into
mainfrom
cursor/fix-asymmetric-loss-gradient-disconnection-c61b
Draft

Fix asymmetric loss gradient disconnection#3
d-ulker wants to merge 3 commits into
mainfrom
cursor/fix-asymmetric-loss-gradient-disconnection-c61b

Conversation

@d-ulker

@d-ulker d-ulker commented Sep 8, 2025

Copy link
Copy Markdown
Owner

Implement robust training monitoring and fix Asymmetric Loss gradient disconnection to prevent unexpected training stalls.

The previous Asymmetric Loss implementation used disable_torch_grad_focal_loss=True, which inadvertently created a torch.no_grad() context, blocking gradient flow and preventing the model from learning. This PR corrects the loss function and introduces a ProgressMonitorCallback to detect training stalls, manage disk space, and improve NCCL communication, ensuring more reliable and recoverable multi-GPU training runs.


Open in Cursor Open in Web

Co-authored-by: denizcan.uelker <denizcan.uelker@mercedes-benz.com>
@cursor

cursor Bot commented Sep 8, 2025

Copy link
Copy Markdown

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @uelkerd! 👋

Your private repo does not have access to Sourcery.

Please upgrade to continue using Sourcery ✨

@coderabbitai

coderabbitai Bot commented Sep 8, 2025

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands and usage tips.

cursoragent and others added 2 commits September 8, 2025 22:38
Co-authored-by: denizcan.uelker <denizcan.uelker@mercedes-benz.com>
Co-authored-by: denizcan.uelker <denizcan.uelker@mercedes-benz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants