Handle ToggleShowDesktop for widget-like windows (conky) properly#45
Open
Caellian wants to merge 1 commit intodanakj:masterfrom
Open
Handle ToggleShowDesktop for widget-like windows (conky) properly#45Caellian wants to merge 1 commit intodanakj:masterfrom
Caellian wants to merge 1 commit intodanakj:masterfrom
Conversation
Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
Author
|
For reference: Following should be used for openbox: own_window_type = 'normal', -- or 'dock'
own_window_hints = 'undecorated,below,sticky,skip_taskbar,skip_pager',One may use With this patch,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding this small heuristic helps
client_should_showproperly handle widget-like apps (e.g. conky).I don't think it causes issues with any other applications because in majority of cases
skip_taskbar,skip_pagerandbeloware really strong hints the app isn't showing as a normal window. The only thing that comes to mind that breaks this assumption is installer backgrounds that were common around 2010 (in which case hiding the installer too would be a bug), but those are not something we often see on Linux.Ideally we'd have a
widgetWM_HINT, but that won't be added to X11 at this point lol.Fixes issue reported in conky#2304.