Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the one
[package.metadata.binstall]entry needed forcargo binstall git-deltato install the prebuilt release binaries.binstall already finds and downloads
delta-<version>-<target>.tar.gz, but it renders its defaultpkg-urltemplates with the binary name (delta) while inferring the archive directory with the crate name (git-delta). It therefore looks forgit-delta-0.20.1-x86_64-unknown-linux-gnu/delta, doesn't find it, reports "please contact with upstream to fix this issue", and falls back to compiling from source. Naming the directory explicitly fixes that. No CI or release-asset changes are needed.Deliberately no
pkg-fmt: leaving it unset makes binstall try every supported format, which is what lets the Windows.zipwork with this same entry.Refs #1587 (the issue carries the design discussion, so this is intentionally not a
Closes).Verification — cargo-binstall 1.24.0,
--strategies crate-meta-data --dry-run, run against this repo's ownCargo.tomlvia--manifest-path:ERROR resolve: When resolving git-delta bin delta is not found … please contact with upstream, then falls back to installing from source.delta-0.20.1-x86_64-unknown-linux-gnu.tar.gzand resolvesdeltafor install.The same metadata also resolves
x86_64-unknown-linux-musl,x86_64-pc-windows-msvc(from the.zip) andaarch64-apple-darwinin dry runs.x86_64-apple-darwinhas no published artifact, so it still falls back to source — that's an artifact gap, not a metadata one.The investigation and the dry-run verification were done with AI assistance; I've reviewed the change.