Conversation
|
Sample output for |
Codecov Report
@@ Coverage Diff @@
## master #1061 +/- ##
==========================================
+ Coverage 88.35% 88.42% +0.06%
==========================================
Files 72 73 +1
Lines 9250 9304 +54
==========================================
+ Hits 8173 8227 +54
Misses 1077 1077
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
apparently this has another subject, I need to check. |
|
Subject discussion continued here: dandisets/000108#10 |
|
@TheChymera - what are the plans for this PR? |
|
@yarikoptic this is old code which @satra said he needed. It's a separate function without a CLI binding, so it would need a re-design from scratch if we still want this. But in that case we should discuss the actual behaviour we want. |
|
we are doing this using notebooks to generate a dashboard for 26 and 108 (both bids datasets). perhaps we can generalize some of that. i think this PR was opened in relation to the validation work in CLI. the dashboard generation could live somewhere else for now, perhaps as a bids summary generator in bids-specification. the other related component is to do appropriate diffs between two states at a higher level (subjects, data modalities, etc., and not just so many assets added/deleted). let's perhaps close this and see if this can be done in bids. |
Very early draft of reporting as discussed with @satra and @yarikoptic .
Already works with
000108and its respective report can be produced withpytest -vvs tests/test_bids_utils.pyMissing: