Skip to content

Update test assertions for enhanced API error messages #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CodyCBakerPhD merged 2 commits into from
Feb 14, 2026
Merged

Update test assertions for enhanced API error messages #1801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ec1f72
Initial plan
Copilot Feb 14, 2026
51dbd8f
Update test expectations for enhanced error messages
Copilot Feb 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 34 additions & 8 deletions dandi/tests/test_dandiarchive.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,11 +588,17 @@ def test_get_nonexistent_dandiset(
parsed_url.get_dandiset(client) # No error
with pytest.raises(NotFoundError) as excinfo:
parsed_url.get_dandiset(client, lazy=False)
assert str(excinfo.value) == "No such Dandiset: '999999'"
assert str(excinfo.value) == (
"No such Dandiset: '999999'. "
"Verify the Dandiset ID is correct and that you have access. "
)
assert list(parsed_url.get_assets(client)) == []
with pytest.raises(NotFoundError) as excinfo:
next(parsed_url.get_assets(client, strict=True))
assert str(excinfo.value) == "No such Dandiset: '999999'"
assert str(excinfo.value) == (
"No such Dandiset: '999999'. "
"Verify the Dandiset ID is correct and that you have access. "
)


@pytest.mark.parametrize("version", ["draft", "0.999999.9999"])
Expand All @@ -608,7 +614,10 @@ def test_get_nonexistent_dandiset_asset_id(
assert list(parsed_url.get_assets(client)) == []
with pytest.raises(NotFoundError) as excinfo:
next(parsed_url.get_assets(client, strict=True))
assert str(excinfo.value) == "No such Dandiset: '999999'"
assert str(excinfo.value) == (
"No such Dandiset: '999999'. "
"Verify the Dandiset ID is correct and that you have access. "
)


def test_get_dandiset_nonexistent_asset_id(text_dandiset: SampleDandiset) -> None:
Expand All @@ -635,7 +644,11 @@ def test_get_nonexistent_asset_id(local_dandi_api: DandiAPI) -> None:
assert list(parsed_url.get_assets(client)) == []
with pytest.raises(NotFoundError) as excinfo:
next(parsed_url.get_assets(client, strict=True))
assert str(excinfo.value) == "No such asset: '00000000-0000-0000-0000-000000000000'"
assert str(excinfo.value) == (
"No such asset: '00000000-0000-0000-0000-000000000000'. "
"Verify the asset ID is correct. "
"Use 'dandi ls' to list available assets."
)


@pytest.mark.parametrize("version_suffix", ["", "@draft", "@0.999999.9999"])
Expand All @@ -648,7 +661,10 @@ def test_get_nonexistent_dandiset_asset_path(
assert list(parsed_url.get_assets(client)) == []
with pytest.raises(NotFoundError) as excinfo:
next(parsed_url.get_assets(client, strict=True))
assert str(excinfo.value) == "No such Dandiset: '999999'"
assert str(excinfo.value) == (
"No such Dandiset: '999999'. "
"Verify the Dandiset ID is correct and that you have access. "
)


def test_get_nonexistent_asset_path(text_dandiset: SampleDandiset) -> None:
Expand All @@ -661,7 +677,11 @@ def test_get_nonexistent_asset_path(text_dandiset: SampleDandiset) -> None:
assert list(parsed_url.get_assets(client)) == []
with pytest.raises(NotFoundError) as excinfo:
next(parsed_url.get_assets(client, strict=True))
assert str(excinfo.value) == "No asset at path 'does/not/exist'"
assert str(excinfo.value) == (
"No asset at path 'does/not/exist' in version draft. "
"Verify the path is correct and the asset exists in this version. "
"Use 'dandi ls' to list available assets."
)


@pytest.mark.parametrize("version_suffix", ["", "@draft", "@0.999999.9999"])
Expand All @@ -677,7 +697,10 @@ def test_get_nonexistent_dandiset_asset_folder(
assert list(parsed_url.get_assets(client)) == []
with pytest.raises(NotFoundError) as excinfo:
next(parsed_url.get_assets(client, strict=True))
assert str(excinfo.value) == "No such Dandiset: '999999'"
assert str(excinfo.value) == (
"No such Dandiset: '999999'. "
"Verify the Dandiset ID is correct and that you have access. "
)


def test_get_nonexistent_asset_folder(text_dandiset: SampleDandiset) -> None:
Expand Down Expand Up @@ -706,7 +729,10 @@ def test_get_nonexistent_dandiset_asset_prefix(
assert list(parsed_url.get_assets(client)) == []
with pytest.raises(NotFoundError) as excinfo:
next(parsed_url.get_assets(client, strict=True))
assert str(excinfo.value) == "No such Dandiset: '999999'"
assert str(excinfo.value) == (
"No such Dandiset: '999999'. "
"Verify the Dandiset ID is correct and that you have access. "
)


def test_get_nonexistent_asset_prefix(text_dandiset: SampleDandiset) -> None:
Expand Down
5 changes: 4 additions & 1 deletion dandi/tests/test_delete.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,10 @@ def test_delete_nonexistent_dandiset(
devel_debug=True,
force=True,
)
assert str(excinfo.value) == "No such Dandiset: '999999'"
assert str(excinfo.value) == (
"No such Dandiset: '999999'. "
"Verify the Dandiset ID is correct and that you have access. "
)
delete_spy.assert_not_called()


Expand Down
Loading