Improve wording for the setup wizard#174
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR improves the wording of the "Enable NAT mode" field in the setup wizard configuration to enhance clarity on when NAT mode can be disabled.
- Revised the description to clearly indicate that NAT mode is assumed when running on a dappnode and can be disabled if the dappnode is publicly exposed.
tolbrino
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the description of the "Enable NAT mode" field in the
setup-wizard.ymlfile to clarify the conditions under which NAT mode can be disabled.setup-wizard.yml: Revised the description to specify that NAT mode can be disabled if the dappnode is publicly exposed, improving clarity and accuracy.