Skip to content

Banner not dissapearing fix#2440

Open
Marketen wants to merge 1 commit into
developfrom
marc/banner-fixes
Open

Banner not dissapearing fix#2440
Marketen wants to merge 1 commit into
developfrom
marc/banner-fixes

Conversation

@Marketen

Copy link
Copy Markdown
Contributor

This pull request improves the handling and consistency of banner notifications for system events (such as host reboot, internet connection, and repository health) in the daemon services. The main focus is on ensuring that banner notifications are managed correctly using correlation IDs, and on adding robust utilities and tests for notification management.

Key changes include:

Host Reboot Notification Logic Improvements:

  • Added a utility function getLatestNotificationByCorrelationId to retrieve the most recent notification for a given correlation ID, filtering out any with errors. This helps prevent duplicate or outdated notifications.
  • Updated the host reboot monitoring logic to check for existing active notifications using the new utility, ensuring only one active banner notification is sent or resolved as needed. The notification logic now consistently uses the core-reboot-required correlation ID. [1] [2] [3]

Banner Notification Consistency:

  • Changed resolved notifications for internet connection and repository health events to set isBanner: true, ensuring these resolved notifications are also displayed as banners for user visibility. [1] [2] [3]

Testing and Utilities:

  • Added unit tests for getLatestNotificationByCorrelationId to verify correct selection of the latest valid notification and proper handling of notifications with errors.

@Marketen Marketen requested a review from a team as a code owner June 10, 2026 16:03
@github-actions

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant