Skip to content

Drop temporary android-sample clone pin #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
phwizard wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Drop temporary android-sample clone pin #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -885,16 +885,9 @@ async function checkSdkUpdate(dir: string, name: string): Promise<void> {
}

const SDK_REPOS: Record<SdkTarget, { repo: string; name: string; branch?: string }> = {
// TEMPORARY: pin to the PR branch that wires the sample's Setup-tab
// defaults to BuildConfig (https://github.com/dappros/ethora-sample-android/pull/1).
// Without this branch, the .env keys we write here (ETHORA_APP_TOKEN /
// USER_EMAIL / USER_PASSWORD) are read but ignored — the sample's
// PlaygroundSessionState still hardcodes BASE app ID + dev-team email/
// password defaults. Drop the `branch` field once PR #1 lands on main.
android: {
repo: "https://github.com/dappros/ethora-sample-android.git",
name: "ethora-sample-android",
branch: "tf/setup-integration-and-ux-fixes",
},
swift: { repo: "https://github.com/dappros/ethora-sample-swift.git", name: "ethora-sample-swift" },
reactjs: { repo: "https://github.com/dappros/ethora-chat-component.git", name: "ethora-chat-component" },
Expand Down