ensure dt window icon is used on Plasma/Wayland#19948
Merged
TurboGit merged 1 commit intodarktable-org:masterfrom Feb 7, 2026
Merged
ensure dt window icon is used on Plasma/Wayland#19948TurboGit merged 1 commit intodarktable-org:masterfrom
TurboGit merged 1 commit intodarktable-org:masterfrom
Conversation
We must set the program name to our desktop file. The icon comes from this file. Fixes darktable-org#19946.
TurboGit
reviewed
Dec 21, 2025
dtorop
added a commit
to dtorop/darktable
that referenced
this pull request
Mar 5, 2026
Covers darktable-org#19948, darktable-org#19949, darktable-org#20227, and darktable-org#20113. Note the latter two bugfixes are also in 5.4.1, so not sure if they shold be mentioned in 5.6.0 release notes.
dtorop
added a commit
to dtorop/darktable
that referenced
this pull request
Mar 6, 2026
TurboGit
pushed a commit
that referenced
this pull request
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting the program name to match our desktop file allows for the icon to come from that file.
Fixes #19946.
Note that this fixes a Wayland/Plasma interaction under GTK 3. A different solution will be necessary for GTK 4 (see #19448), apparently via setting the desktop file basename via
gtk_application_new().