Skip to content

adjustments to styles module#20480

Open
deekayhd wants to merge 6 commits intodarktable-org:masterfrom
deekayhd:styles_preview
Open

adjustments to styles module#20480
deekayhd wants to merge 6 commits intodarktable-org:masterfrom
deekayhd:styles_preview

Conversation

@deekayhd
Copy link
Contributor

As discussed in PR #20473 I have made the following changes to the styles module:

  • The combobox for the preview, where a large, default, or no preview could be chosen, has been replaced with a checkbox to hide the preview on the tooltip.
  • The preview size can now be set in the module preferences. Like before, there are two options: default and large.
  • the "hide preview" checkbox is now above the "create duplicate" checkbox, not in the same row. This is better for very narrow side panels (as reported in the mentioned PR).

The actual sizes in pixels of default and large remain as "hidden" preferences.

@deekayhd
Copy link
Contributor Author

Screenshot from 2026-03-10 16-48-15

@TurboGit TurboGit modified the milestone: 5.6 Mar 10, 2026
Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks!

GtkWidget *win = dt_ui_main_window(darktable.gui->ui);
GtkWidget *dialog = gtk_dialog_new_with_buttons(_("style preview settings"), GTK_WINDOW(win),
GTK_DIALOG_DESTROY_WITH_PARENT,
_("cancel"), GTK_RESPONSE_NONE,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add key accels:

cancel -> _cancel
save   -> _save

gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(d->hide_preview),
dt_conf_get_bool("ui_last/styles_hide_preview"));
gtk_widget_set_tooltip_text(d->hide_preview,
_("hide preview of style applied to image"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have:
"change size of preview on tooltip of style"
Maybe here:
"hide preview of style on tooltip"

I'm not a native English speaker, bear with me :)

@TurboGit TurboGit added priority: low core features work as expected, only secondary/optional features don't scope: UI user interface and interactions scope: DAM managing files, collections, archiving, metadata, etc. release notes: pending labels Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: low core features work as expected, only secondary/optional features don't release notes: pending scope: DAM managing files, collections, archiving, metadata, etc. scope: UI user interface and interactions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants