Skip to content

Upgrade cronet_http to JNI 1.0 and JNIGen 0.16.0#1940

Merged
brianquinlan merged 2 commits into
dart-lang:masterfrom
brianquinlan:jni10
Jun 23, 2026
Merged

Upgrade cronet_http to JNI 1.0 and JNIGen 0.16.0#1940
brianquinlan merged 2 commits into
dart-lang:masterfrom
brianquinlan:jni10

Conversation

@brianquinlan

@brianquinlan brianquinlan commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Fixes #1938

--

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.

@github-actions

Copy link
Copy Markdown

PR Health

Unused Dependencies ⚠️
Package Status
cronet_http
❗ Show Issues
These packages are used outside lib/ but are not dev_dependencies:
* flutter_test
* http_client_conformance_tests
* http_image_provider
* integration_test
* provider
* test
These packages are only used outside lib/ and should be downgraded to dev_dependencies:
* flutter
These packages may be unused, or you may be using assets from these packages:
* dart_flutter_team_lints
* yaml_edit
Failed to update packages.

For details on how to fix these, see dependency_validator.

This check can be disabled by tagging the PR with skip-unused-dependencies-check.

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
cronet_http Non-Breaking 1.8.0 1.9.0-wip 1.9.0-wip ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Coverage ⚠️
File Coverage
pkgs/cronet_http/lib/src/cronet_client.dart 💔 Not covered
pkgs/cronet_http/lib/src/jni/jni_bindings.dart 💔 Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

License Headers ✔️
// Copyright (c) 2026, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/cupertino_http/example/example.dart
pkgs/http/example/main.dart
pkgs/http_multi_server/test/cert.dart

This check can be disabled by tagging the PR with skip-license-check.

@brianquinlan brianquinlan requested a review from goderbauer June 22, 2026 22:13

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianquinlan brianquinlan merged commit 99a8c99 into dart-lang:master Jun 23, 2026
47 checks passed
@brianquinlan brianquinlan deleted the jni10 branch June 23, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump JNI to 1.0

2 participants