[native_toolchain_c] Fix #3327 native_toolchain_c vswhere selection#3328
[native_toolchain_c] Fix #3327 native_toolchain_c vswhere selection#3328Chaos02 wants to merge 1 commit intodart-lang:mainfrom
Conversation
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with Breaking changes ✔️
This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with |
| '-products', | ||
| '*', | ||
| '-requires', | ||
| 'Microsoft.VisualStudio.Component.VC.Tools.x86.x64', |
There was a problem hiding this comment.
This is only for if the target is Architecture.x64. For Architecture.arm64 it should be Microsoft.VisualStudio.Component.VC.Tools.ARM64. But, VisualStudioResolver doesn't take a target architecture, we're trying to find one visual studio.
So maybe a better fix is to first try 'Microsoft.VisualStudio.Component.VC.Tools.x86.x64', then add all instances with parseVswhere and then do the same with Microsoft.VisualStudio.Component.VC.Tools.ARM64.
We should probably try to run a CI on runs-on: windows-11-arm in .github/workflows/native.yaml to cover the CI. (But we can do that as a separate PR.)
Fixes Native_toolchain_c trying to use Microsoft SQL Server Management Studio as a msvc provider
Related Issues
Fixes #3327
PR Checklist
dart tool/ci.dart --alllocally and resolved all issues identified. This ensures the PR is formatted, has no lint errors, and ran all code generators. This applies to the packages part of the toplevelpubspec.yamlworkspace.CHANGELOG.mdfor the relevant packages. (Not needed for small changes such as doc typos).