[objective_c] Implement NSNumber methods for bool#3331
Open
knopp wants to merge 2 commits intodart-lang:mainfrom
Open
[objective_c] Implement NSNumber methods for bool#3331knopp wants to merge 2 commits intodart-lang:mainfrom
knopp wants to merge 2 commits intodart-lang:mainfrom
Conversation
Contributor
Author
|
Not sure why there are so many changes in generated bindings, is that expected? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
bool.toNSNumber()extension method,NSNumber.isBoolcheck and add converter support for bool.Related Issues
List which issues are fixed by this PR. Use the syntax
Fixes #1234.PR Checklist
dart tool/ci.dart --alllocally and resolved all issues identified. This ensures the PR is formatted, has no lint errors, and ran all code generators. This applies to the packages part of the toplevelpubspec.yamlworkspace.CHANGELOG.mdfor the relevant packages. (Not needed for small changes such as doc typos).